#format wiki
#language en
#pragma section-numbers off
#acl IanRiley:read,write,delete,revert,admin All:read

[[RileyLink|{{attachment:RileyLinkFiles/public/[ir].png||align="left",height=35,width=35,target="./RileyLink"}}]]{{attachment:RileyLinkFiles/public/blank.png||align="left",height=35,width=10}}
= Patch - Comment Parsing =
-----
== Issue ==

A bug identified in http://moinmo.in/MoinMoinBugs/CommentBreaksListNumbering has been an issue for awhile.

When a comment line (viz. `## comment` is placed with a list, the list is broken.  MoinMoin stops this break occurring in tables but not in lists.

These comment lines only appear in the raw text of a page, and cannot be revealed by toggling comments as with `/* comment */` (if enabled by user preferences). So it would make sense to just ignore them and prevent parsing in all instances, not just with tables.

== Patch ==

A simple patch to the parser `text_moin_wiki.py` can resolve this issue.

Copy the parser `text_moin_wiki.py` from `MoinMoin/parser` to `.../data/plugin/parser`, and add the following patch.

{{{#!highlight python

             # ignore processing instructions
             if self.in_processing_instructions:
                 found = False
                 for pi in ("##", "#format", "#refresh", "#redirect", "#deprecated",
                            "#pragma", "#form", "#acl", "#language"):
                     if line.lower().startswith(pi):
                         self.request.write(self.formatter.comment(line))
                         found = True
                         break
                 if not found:
                     self.in_processing_instructions = 0
                 else:
                     continue # do not parse this line
                    
+            # ignore comment lines beyond processing instructions
+            if line.startswith("##") and not self.in_pre:
+                continue # do not parse this line
+ 
}}}

Within a parser section (`self.in_pre == true`), `##comment` lines are not ignored, unless the parser section is `{{{#!wiki...`.

The patch makes the checking for lines starting with `##` after this point redundant, but this does not seem to create a problem.

This patch has been checked against [[slideshow_wiki.py]] parser, which uses `##slide` and `##notes` as tokens for delimiting slides and slide notes, and it does not prevent the slideshow parser working. However, if a list is split across two slides, the numbering for the second slides with need to be restarted explicitly (e.g. `1.#7`). So little has been gained by the patch in this context.

-----

 Hits:: <<Hits>>