#format wiki
#language en
#pragma section-numbers off
#acl IanRiley:read,write,delete,revert,admin All:read

[[RileyLink|{{attachment:RileyLinkFiles/public/[ir].png||align="left",height=35,width=35,target="./RileyLink"}}]]{{attachment:RileyLinkFiles/public/blank.png||align="left",height=35,width=10}}
= Patch - SlideShow Action =
-----
== Issues ==

 1. !SlideShow action inserts an image (logo) before the slide title. The image file used is coded into `SlideShow.css`. It would be good to be able to alter this from within the page to be displayed as a slide. This could be done with `#pragma logo` as it is already done for `#pragma date` and `#pragma author`.

 2. !SideShow action inserts an edit link even for pages the users does not have the right to edit. Yes, in such cases the link is disabled. However, it would be neater if it was not inserted at all.

== Patch ==

Copy the parser `SlideShow.py` from `MoinMoin/action` to `.../data/plugin/action`, and add the following patch.

'''Issue 1'''

Add a new function.

{{{#!highlight python

     def item_author(self):
         return wikiutil.escape(self.request.getPragma('author', defval=''))
 
+    def item_logo(self):
+        return wikiutil.escape(self.request.getPragma('logo', defval='moinmoin.png'))
}}}

Modify the HTML template string, so the standard stylesheet is loaded then h1::before is overridden.

{{{#!highlight html
-    <link rel="stylesheet" type="text/css" charset="utf-8" media="all"
-        href="%(theme_url)s/css/%(action_name)s.css">
+    <STYLE TYPE="text/css" CHARSET="utf-8" MEDIA="all">
+    <!--
+      @import url(%(theme_url)s/css/%(action_name)s.css);
+      h1::before {content:url(%(theme_url)s/../common/%(logo)s);
+        padding-right:10px; display: inline-block; vertical-align: middle;
+      }
+    -->
+    </STYLE>
}}}

To specify the logo file use `#pragma logo filename` where `filename` might be `slide-logo.png` or the like. Make sure the file is copied into the specified location.
 
'''Issue 2'''

Modify the existing `item_navigation_edit()` function.

{{{#!highlight python
     def item_navigation_edit(self):
         _ = self.request.getText
         text = _('Edit')
         if self.request.user.may.write(self.page.page_name):
-            return self.linkToPage(text, 'action=edit', title=_('Edit slide show'))
-        return self.disabledLink(text, title=_("You are not allowed to edit this page."))
+            link = self.linkToPage(text, 'action=edit', title=_('Edit slide show'))
+            return '<li>%s</li>' % link
+        return ''
}}}

Modify the HTML template string, so that link list item is only added if the user has write privileges.

{{{#!highlight html
-            <li>%(navigation_edit)s</li>
+            %(navigation_edit)s
}}}
-----

 Hits:: <<Hits>>