Patch - SlideShow Action

Issues

1. SlideShow action inserts an image (logo) before the slide title. The image file used is coded into SlideShow.css. It would be good to be able to alter this from within the page to be displayed as a slide. This could be done with #pragma logo as it is already done for #pragma date and #pragma author.

2. SideShow action inserts an edit link even for pages the users does not have the right to edit. Yes, in such cases the link is disabled. However, it would be neater if it was not inserted at all.

Patch

Copy the parser SlideShow.py from MoinMoin/action to .../data/plugin/action, and add the following patch.

Issue 1

Add a new function.

   1      def item_author(self):
   2          return wikiutil.escape(self.request.getPragma('author', defval=''))
   3  
   4 +    def item_logo(self):
   5 +        return wikiutil.escape(self.request.getPragma('logo', defval='moinmoin.png'))

Modify the HTML template string, so the standard stylesheet is loaded then h1::before is overridden.

   1 -    <link rel="stylesheet" type="text/css" charset="utf-8" media="all"
   2 -        href="%(theme_url)s/css/%(action_name)s.css">
   3 +    <STYLE TYPE="text/css" CHARSET="utf-8" MEDIA="all">
   4 +    <!--
   5 +      @import url(%(theme_url)s/css/%(action_name)s.css);
   6 +      h1::before {content:url(%(theme_url)s/../common/%(logo)s);
   7 +        padding-right:10px; display: inline-block; vertical-align: middle;
   8 +      }
   9 +    -->
  10 +    </STYLE>

To specify the logo file use #pragma logo filename where filename might be slide-logo.png or the like. Make sure the file is copied into the specified location.

Issue 2

Modify the existing item_navigation_edit() function.

   1      def item_navigation_edit(self):
   2          _ = self.request.getText
   3          text = _('Edit')
   4          if self.request.user.may.write(self.page.page_name):
   5 -            return self.linkToPage(text, 'action=edit', title=_('Edit slide show'))
   6 -        return self.disabledLink(text, title=_("You are not allowed to edit this page."))
   7 +            link = self.linkToPage(text, 'action=edit', title=_('Edit slide show'))
   8 +            return '<li>%s</li>' % link
   9 +        return ''

Modify the HTML template string, so that link list item is only added if the user has write privileges.

   1 -            <li>%(navigation_edit)s</li>
   2 +            %(navigation_edit)s

Hits

311