Patch - Sticky Messages
Issue
Messages displayed above the page content are usually temporary and can be cleared by clicking the Clear message link. However, with the implementation of page scheduling using the schedule.py parser, some messages on page availability or validity of scheduling arguments should not be cleared. To achieve this the ThemeBase class can be patched as follows.
Patch
A simple patch to the ThemeBase class MoinMoin.theme.__init__.py can add stickness to page messages.
1 def msg(self, d):
2 """ Assemble the msg display
3
4 Display a message with a widget or simple strings with a clear message link.
5
6 @param d: parameter dictionary
7 @rtype: unicode
8 @return: msg display html
9 """
10 _ = self.request.getText
11 msgs = d['msg']
12
13 result = u""
14 + sticky = True # added stickiness for messages that cannot be cleared [IanRiley 06.01.19]
15 close = d['page'].link_to(self.request, text=_('Clear message'), css_class="clear-link")
16 for msg, msg_class in msgs:
17 + if msg_class[0] != '!': # leading '!' means a sticky message
18 + sticky = False # so at least one msg is non-sticky
19 + else:
20 + msg_class = msg_class.replace('!', '', 1) # remove leading '!'
21 try:
22 result += u'<p>%s</p>' % msg.render()
23 close = ''
24 except AttributeError:
25 if msg and msg_class:
26 result += u'<p><div class="%s">%s</div></p>' % (msg_class, msg)
27 elif msg:
28 result += u'<p>%s</p>\n' % msg
29 if result:
30 - html = result + close
31 + html = result
32 + if not sticky: # only add close when at least one msg is non-sticky
33 + html = result + close
34 return u'<div id="message">\n%s\n</div>\n' % html
35 else:
36 return u''
37
38 return u'<div id="message">\n%s\n</div>\n' % html
To make a message sticky, an exclamation mark has to be added to the front of the message in the code generating the message. This suffix is removed before the message is displayed.
If preferred, the msg function of the ThememBase could be overridden it wiki.data.plugin.theme, rather in the main code.
- Hits
193